Skip to content

Tags: show icon names, align card styling#44

Merged
StuartMeeks merged 2 commits into
mainfrom
fix/tags-card-and-hex
Jun 1, 2026
Merged

Tags: show icon names, align card styling#44
StuartMeeks merged 2 commits into
mainfrom
fix/tags-card-and-hex

Conversation

@StuartMeeks

Copy link
Copy Markdown
Owner

Pre-v0.1.0 polish to the Tags view.

Changes

  1. Icon text box shows the friendly name, not a tofu box. A chosen glyph is now shown by its catalogue name (e.g. Settings), falling back to its hex code point (e.g. E8EC) when the glyph isn't in the catalogue. You can also type a name (case-insensitive) and it resolves to the glyph, or type a code as before. The box commits on focus loss, so the friendly form only replaces typed input once editing finishes — never mid-keystroke.

  2. Card styling aligned. Tag cards now use the same CardBackgroundFillColorDefaultBrush + 1px CardStrokeColorDefaultBrush border (corner 8 / padding 16) as the Shared parameters and Trash cards. Previously they were a borderless grey fill (SubtleFillColorSecondaryBrush), which stood out in Light theme. Trash already matched; Settings uses the toolkit SettingsCard, which renders with the same card brushes — so Tags, Shared parameters, Trash and Settings are now consistent on background and border. (Content width was already consistent: all four use MaxWidth=720, Padding=24, HorizontalAlignment=Stretch.)

How

  • New Core GlyphNameLookup (two-way glyph↔name map). TagIconRowViewModel.GlyphText resolves display/edit through it, falling back to hex via the existing GlyphInput.
  • ShellViewModel gained an optional IGlyphCatalogueProvider: production DI injects it (names work); the existing unit tests construct ShellViewModel without it (lookup empty → hex fallback), so nothing broke.
  • OpenTagIcons builds the lookup from the catalogue when the view opens.

Testing

  • 231 Core unit tests pass (incl. new GlyphText name-display, name→glyph resolution, and hex-fallback cases).
  • WinUI head compile-verified on the Windows build agent: 0 warnings, 0 errors.

Note

The custom cards use corner radius 8; the toolkit SettingsCard defaults to 4 — a pre-existing difference left as-is, since the brief was to match tag cards to the Shared parameters cards (8). Easy to unify later if wanted.

🤖 Generated with Claude Code

StuartMeeks and others added 2 commits June 1, 2026 08:36
The icon text box now shows a picked glyph's friendly catalogue name
(e.g. Settings) instead of a tofu box, falling back to its hex code
point when the glyph isn't in the catalogue, and resolves a typed name
back to its glyph. It commits on focus loss so the friendly form only
replaces typed input once editing finishes. Tag cards now use the same
background and 1px border as the Shared parameters, Trash and Settings
cards (previously a borderless grey fill).

ShellViewModel takes an optional IGlyphCatalogueProvider so the name
lookup is available in production while unit tests stay unchanged.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@StuartMeeks StuartMeeks merged commit e6670a8 into main Jun 1, 2026
6 checks passed
@StuartMeeks StuartMeeks deleted the fix/tags-card-and-hex branch June 1, 2026 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant